-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: add searchsorted examples #36411 #37370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @Mikhaylov-yv! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-10-25 16:50:32 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Mikhaylov-yv for the PR!
A comment
2 2020-10-23 | ||
dtype: datetime64[ns] | ||
|
||
>>> ser.searchsorted('3/14/2000') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry if i'm being slow but shouldn't this return 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are absolutely right. thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need to use the same dates in the constructed series and the output
(that's why CI is red atm. Once these are fixed I think you're ready to go)
Thanks @Mikhaylov-yv |
* DOC: add searchsorted examples * Update base.py * corrected values * Update base.py
* DOC: add searchsorted examples * Update base.py * corrected values * Update base.py
DOC: add searchsorted examples #36411